Ab replace pd 02 - #39
Merged
Merged
Conversation
tswast
reviewed
Jul 13, 2026
| import uuid | ||
| from pathlib import Path | ||
|
|
||
| sys.path.insert(0, str(Path(__file__).parent.parent)) |
Collaborator
There was a problem hiding this comment.
Do we need to update our pyproject.toml to make sure leanframe can be imported without such changes?
tswast
reviewed
Jul 13, 2026
|
|
||
| # Create handler to analyze nested structure | ||
| print("\nCreating DataFrameHandler to analyze nested structure...") | ||
| handler = DataFrameHandler(customers_df) |
Collaborator
There was a problem hiding this comment.
Is DataFrameHandler normally part of the public interface?
Collaborator
Author
There was a problem hiding this comment.
as dicussed, will try to hide both handlers and make them internal, private members of DataFrame or find a similar solution
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here the new code and some new demo/ changed demos, directly comparing pandas and not ibis base things. As soon as either DataFrame is turned into a leanframe Dataframe, there is no difference any more. As intended!